[PATCH v3 10/15] drivers/firmware/sdei: Cleanup on cross call function
Gavin Shan
gshan at redhat.com
Mon Jul 27 22:59:50 EDT 2020
This applies cleanup on the cross call functions, no functional
changes are introduced:
* Refactor CROSSCALL_INIT to use "do { ... } while (0)" to be
compatible with scripts/checkpatch.pl
* Use smp_call_func_t for @fn argument in sdei_do_cross_call()
* Remove unnecessary space before @event in sdei_do_cross_call()
Signed-off-by: Gavin Shan <gshan at redhat.com>
Reviewed-by: Jonathan Cameron <Jonathan.Cameron at huawei.com>
---
v3: Corrected spellings in changelog
Drop tabs between type and field for struct sdei_crosscall_args
Use smp_call_func_t for @fn argument in sdei_do_cross_call()
---
drivers/firmware/arm_sdei.c | 14 +++++++++-----
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a/drivers/firmware/arm_sdei.c b/drivers/firmware/arm_sdei.c
index c8e894098c56..5560c8880631 100644
--- a/drivers/firmware/arm_sdei.c
+++ b/drivers/firmware/arm_sdei.c
@@ -78,11 +78,15 @@ struct sdei_crosscall_args {
int first_error;
};
-#define CROSSCALL_INIT(arg, event) (arg.event = event, \
- arg.first_error = 0, \
- atomic_set(&arg.errors, 0))
-
-static inline int sdei_do_cross_call(void *fn, struct sdei_event * event)
+#define CROSSCALL_INIT(arg, event) \
+ do { \
+ arg.event = event; \
+ arg.first_error = 0; \
+ atomic_set(&arg.errors, 0); \
+ } while (0)
+
+static inline int sdei_do_cross_call(smp_call_func_t fn,
+ struct sdei_event *event)
{
struct sdei_crosscall_args arg;
--
2.23.0
More information about the linux-arm-kernel
mailing list