[PATCH v4 1/3] arm64: dts: Add a device tree for the Librem 5 phone

Pavel Machek pavel at ucw.cz
Mon Jul 27 08:02:40 EDT 2020


Hi!

> +	pwmleds {
> +		compatible = "pwm-leds";
> +
> +		blue {
> +			label = "blue:status";
> +			max-brightness = <248>;
> +			pwms = <&pwm2 0 50000>;
> +		};
> +
> +		green {
> +			label = "green:status";
> +			max-brightness = <248>;
> +			pwms = <&pwm4 0 50000>;
> +		};
> +
> +		red {
> +			label = "red:status";
> +			max-brightness = <248>;
> +			pwms = <&pwm3 0 50000>;
> +		};
> +	};

Can we postpone this?

1) green:status is not really name used anywhere else

2) this should really use multicolor framework, as it is single LED,
not three of them.

Fixing that in future will be hard :-(.
								Pavel
								
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20200727/aa9d746d/attachment.sig>


More information about the linux-arm-kernel mailing list