[PATCH v31 03/12] leds: lp50xx: Add the LP50XX family of the RGB LED driver

Pavel Machek pavel at ucw.cz
Tue Jul 21 17:07:24 EDT 2020


On Thu 2020-07-16 13:19:58, Dan Murphy wrote:
> Introduce the LP5036/30/24/18/12/9 RGB LED driver.
> The difference in these parts are the number of
> LED outputs where the:
> 
> LP5036 can control 36 LEDs
> LP5030 can control 30 LEDs
> LP5024 can control 24 LEDs
> LP5018 can control 18 LEDs
> LP5012 can control 12 LEDs
> LP5009 can control 9 LEDs
> 
> The device has the ability to group LED output into control banks
> so that multiple LED banks can be controlled with the same mixing and
> brightness.  Inversely the LEDs can also be controlled independently.
> 
> Acked-by: Jacek Anaszewski <jacek.anaszewski at gmail.com>
> Signed-off-by: Dan Murphy <dmurphy at ti.com>

> +/*
> + * struct lp50xx_chip_info -
> + * @num_leds: number of LED outputs available on the device
> + * @led_brightness0_reg: first brightness register of the device
> + * @mix_out0_reg: first color mix register of the device
> + * @bank_brt_reg: bank brightness register
> + * @bank_mix_reg: color mix register
> + * @reset_reg: device reset register
> + */

Should have /** if this is kerneldoc.

> +		init_data.fwnode = child;
> +		num_colors = 0;
> +
> +		/* There are only 3 LEDs per module otherwise they should be
> +		 * banked which also is presented as 3 LEDs
> +		 */

This is not usual comment style for kernel. (And add . at end of
sentence).

Best regards,
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20200721/3c6d44f9/attachment.sig>


More information about the linux-arm-kernel mailing list