[PATCH 02/14] drivers/firmware/sdei: Common block for failing path in sdei_event_create()

[James Morse]

Hi Gavin,

On 06/07/2020 06:47, Gavin Shan wrote:
> The failing path in sdei_event_create() is to free SDEI event and
> return the corresponding error. This introduces common block of
> code for that to avoid duplicated logics.

By replacing it with slightly different duplicated logic?
If there were some kind of state to unwind here, I'd agree a single block to return from
is less likely to have bugs. Until then, this change is just churn.


> By the way, the function
> scoped variables are also reordered according to their importance.

Please: Never do this.

The 'order' is usually to make it easier to resolve merge conflicts. If two people add an
entry, at the same time. Its normally a 'fir' tree, and all that really matters is its
consistent. This change is just churn.


No Thanks,

James