[PATCH v2 1/8] usb: dwc2: gadget: Make use of GINTMSK2

Felipe Balbi balbi at kernel.org
Tue Jul 21 05:43:57 EDT 2020


Minas Harutyunyan <Minas.Harutyunyan at synopsys.com> writes:

> On 7/15/2020 1:32 PM, Lee Jones wrote:
>> The value obtained from GINTSTS2 should be masked with the GINTMSK2
>> value.  Looks like this has been broken since
>> dwc2_gadget_wkup_alert_handler() was added back in 2018.
>> 
>> Also fixes the following W=1 warning:
>> 
>>   drivers/usb/dwc2/gadget.c: In function ‘dwc2_gadget_wkup_alert_handler’:
>>   drivers/usb/dwc2/gadget.c:259:6: warning: variable ‘gintmsk2’ set but not used [-Wunused-but-set-variable]
>>   259 | u32 gintmsk2;
>>   | ^~~~~~~~
>> 
>> Cc: Minas Harutyunyan <hminas at synopsys.com>
>> Cc: Ben Dooks <ben at simtec.co.uk>
>> Fixes: 187c5298a1229 ("usb: dwc2: gadget: Add handler for WkupAlert interrupt")
>> Signed-off-by: Lee Jones <lee.jones at linaro.org>
>
> Acked-by: Minas Harutyunyan <hminas at synopsys.com>

Should I apply the entire series or only 1/8?

-- 
balbi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20200721/cf04be10/attachment.sig>


More information about the linux-arm-kernel mailing list