[PATCH v4 08/16] thermal: sun8i: add TEMP_CALIB_MASK for calibration data in sun50i_h6_ths_calibrate

Frank Lee tiny.windzz at gmail.com
Mon Jul 20 05:27:29 EDT 2020


HI,
On Fri, Jul 17, 2020 at 3:56 PM Daniel Lezcano
<daniel.lezcano at linaro.org> wrote:
>
> On 17/07/2020 09:35, Frank Lee wrote:
> > On Fri, Jul 17, 2020 at 12:26 PM Daniel Lezcano
> > <daniel.lezcano at linaro.org> wrote:
> >>
> >> On 14/07/2020 09:13, Frank Lee wrote:
> >>> From: Yangtao Li <frank at allwinnertech.com>
> >>>
> >>> For sun50i_h6_ths_calibrate(), the data read from nvmem needs a round of
> >>> calculation. On the other hand, the newer SOC may store other data in
> >>> the space other than 12bit sensor data. Add mask operation to read data
> >>> to avoid conversion error.
> >>>
> >>> Signed-off-by: Yangtao Li <frank at allwinnertech.com>
> >>> Reviewed-by: Yangtao Li <tiny.windzz at gmail.com>
> >>
> >> Can you clarify these SoB ?
> >
> > Previously I used 'Signed-off-by: Yangtao Li <tiny.windzz at gmail.com>',
> > maybe this should be removed directly?
> >
> >>
> >> Frank Lee==Yangtao Li==frank at allwinnertech.com==tiny.windzz at gmail.com ?
> >>
> >
> > Yeah.
>
> You are not supposed to add reviewed-by yourself. Please remove it.

Should I resend the entire series or just the thermal patch?
What about those that have been applied.

Thx,
Yangtao



More information about the linux-arm-kernel mailing list