[PATCH RESEND 2/3] usb: gadget: udc: atmel: fix uninitialized read in debug printk

Alexandre Belloni alexandre.belloni at bootlin.com
Wed Jul 15 17:45:51 EDT 2020


On 08/07/2020 20:04:09+0200, Michał Mirosław wrote:
> Fixed commit moved the assignment of 'req', but did not update a
> reference in the DBG() call. Use the argument as it was renamed.
> 
> Fixes: 5fb694f96e7c ("usb: gadget: udc: atmel: fix possible oops when unloading module")
> Signed-off-by: Michał Mirosław <mirq-linux at rere.qmqm.pl>
Acked-by: Alexandre Belloni <alexandre.belloni at bootlin.com>

> ---
>  drivers/usb/gadget/udc/atmel_usba_udc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/gadget/udc/atmel_usba_udc.c b/drivers/usb/gadget/udc/atmel_usba_udc.c
> index 9153e220848d..9342a3d24963 100644
> --- a/drivers/usb/gadget/udc/atmel_usba_udc.c
> +++ b/drivers/usb/gadget/udc/atmel_usba_udc.c
> @@ -865,7 +865,7 @@ static int usba_ep_dequeue(struct usb_ep *_ep, struct usb_request *_req)
>  	u32 status;
>  
>  	DBG(DBG_GADGET | DBG_QUEUE, "ep_dequeue: %s, req %p\n",
> -			ep->ep.name, req);
> +			ep->ep.name, _req);
>  
>  	spin_lock_irqsave(&udc->lock, flags);
>  
> -- 
> 2.20.1
> 

-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com



More information about the linux-arm-kernel mailing list