[PATCH 13/13] cpufreq: amd_freq_sensitivity: Remove unused ID structs

Kim Phillips kim.phillips at amd.com
Tue Jul 14 17:13:31 EDT 2020


On 7/14/20 4:02 PM, Lee Jones wrote:
> On Tue, 14 Jul 2020, Kim Phillips wrote:
>> On 7/14/20 9:50 AM, Lee Jones wrote:
>>> Can't see them being used anywhere and the compiler doesn't complain
>>> that they're missing, so ...
>>>
>>> Fixes the following W=1 kernel build warning(s):
>>>
>>>  drivers/cpufreq/amd_freq_sensitivity.c:147:32: warning: ‘amd_freq_sensitivity_ids’ defined but not used [-Wunused-const-variable=]
>>>  147 | static const struct x86_cpu_id amd_freq_sensitivity_ids[] = {
>>>  | ^~~~~~~~~~~~~~~~~~~~~~~~
>>>
>>> Cc: Jacob Shin <jacob.shin at amd.com>
>>> Signed-off-by: Lee Jones <lee.jones at linaro.org>
>>> ---
>>
>> Same comment as for patch 9/13: these are used automatic module loading.
> 
> How does that work?
> 
> Could you point me to the code which handles that please?

It's MODULE_DEVICE_TABLE magic.

Kim



More information about the linux-arm-kernel mailing list