[PATCH v3 4/6] mm: don't export memory_add_physaddr_to_nid in arch specific directory
Justin He
Justin.He at arm.com
Thu Jul 9 05:36:42 EDT 2020
Hi David
> -----Original Message-----
> From: David Hildenbrand <david at redhat.com>
> Sent: Thursday, July 9, 2020 5:19 PM
> To: Mike Rapoport <rppt at linux.ibm.com>; Matthew Wilcox
> <willy at infradead.org>
> Cc: Justin He <Justin.He at arm.com>; Catalin Marinas
> <Catalin.Marinas at arm.com>; Will Deacon <will at kernel.org>; Tony Luck
> <tony.luck at intel.com>; Fenghua Yu <fenghua.yu at intel.com>; Yoshinori Sato
> <ysato at users.sourceforge.jp>; Rich Felker <dalias at libc.org>; Dave Hansen
> <dave.hansen at linux.intel.com>; Andy Lutomirski <luto at kernel.org>; Peter
> Zijlstra <peterz at infradead.org>; Thomas Gleixner <tglx at linutronix.de>;
> Ingo Molnar <mingo at redhat.com>; Borislav Petkov <bp at alien8.de>;
> x86 at kernel.org; H. Peter Anvin <hpa at zytor.com>; Dan Williams
> <dan.j.williams at intel.com>; Vishal Verma <vishal.l.verma at intel.com>; Dave
> Jiang <dave.jiang at intel.com>; Andrew Morton <akpm at linux-foundation.org>;
> Baoquan He <bhe at redhat.com>; Chuhong Yuan <hslester96 at gmail.com>; Logan
> Gunthorpe <logang at deltatee.com>; Masahiro Yamada <masahiroy at kernel.org>;
> Michal Hocko <mhocko at suse.com>; linux-arm-kernel at lists.infradead.org;
> linux-kernel at vger.kernel.org; linux-ia64 at vger.kernel.org; linux-
> sh at vger.kernel.org; linux-nvdimm at lists.01.org; linux-mm at kvack.org;
> Jonathan Cameron <Jonathan.Cameron at huawei.com>; Kaly Xin <Kaly.Xin at arm.com>
> Subject: Re: [PATCH v3 4/6] mm: don't export memory_add_physaddr_to_nid in
> arch specific directory
>
> On 09.07.20 11:18, Mike Rapoport wrote:
> > On Thu, Jul 09, 2020 at 03:11:04AM +0100, Matthew Wilcox wrote:
> >> On Thu, Jul 09, 2020 at 10:06:27AM +0800, Jia He wrote:
> >>> After a general version of __weak memory_add_physaddr_to_nid
> implemented
> >>> and exported , it is no use exporting twice in arch directory even if
> >>> e,g, ia64/x86 have their specific version.
> >>>
> >>> This is to suppress the modpost warning:
> >>> WARNING: modpost: vmlinux: 'memory_add_physaddr_to_nid' exported twice.
> >>> Previous export was in vmlinux
> >>
> >> It's bad form to introduce a warning and then send a follow-up patch to
> >> fix the warning. Just fold this patch into patch 1/6.
> >
> > Moreover, I think that patches 1-4 can be merged into one.
> >
>
> +1
Okay, will update, thanks
--
Cheers,
Justin (Jia He)
More information about the linux-arm-kernel
mailing list