[PATCH v3 4/6] mm: don't export memory_add_physaddr_to_nid in arch specific directory

[Justin He]

Hi Matthew

> -----Original Message-----
> From: Matthew Wilcox <willy at infradead.org>
> Sent: Thursday, July 9, 2020 10:11 AM
> To: Justin He <Justin.He at arm.com>
> Cc: Catalin Marinas <Catalin.Marinas at arm.com>; Will Deacon
> <will at kernel.org>; Tony Luck <tony.luck at intel.com>; Fenghua Yu
> <fenghua.yu at intel.com>; Yoshinori Sato <ysato at users.sourceforge.jp>; Rich
> Felker <dalias at libc.org>; Dave Hansen <dave.hansen at linux.intel.com>; Andy
> Lutomirski <luto at kernel.org>; Peter Zijlstra <peterz at infradead.org>;
> Thomas Gleixner <tglx at linutronix.de>; Ingo Molnar <mingo at redhat.com>;
> Borislav Petkov <bp at alien8.de>; David Hildenbrand <david at redhat.com>;
> x86 at kernel.org; H. Peter Anvin <hpa at zytor.com>; Dan Williams
> <dan.j.williams at intel.com>; Vishal Verma <vishal.l.verma at intel.com>; Dave
> Jiang <dave.jiang at intel.com>; Andrew Morton <akpm at linux-foundation.org>;
> Baoquan He <bhe at redhat.com>; Chuhong Yuan <hslester96 at gmail.com>; Mike
> Rapoport <rppt at linux.ibm.com>; Logan Gunthorpe <logang at deltatee.com>;
> Masahiro Yamada <masahiroy at kernel.org>; Michal Hocko <mhocko at suse.com>;
> linux-arm-kernel at lists.infradead.org; linux-kernel at vger.kernel.org; linux-
> ia64 at vger.kernel.org; linux-sh at vger.kernel.org; linux-nvdimm at lists.01.org;
> linux-mm at kvack.org; Jonathan Cameron <Jonathan.Cameron at huawei.com>; Kaly
> Xin <Kaly.Xin at arm.com>
> Subject: Re: [PATCH v3 4/6] mm: don't export memory_add_physaddr_to_nid in
> arch specific directory
> 
> On Thu, Jul 09, 2020 at 10:06:27AM +0800, Jia He wrote:
> > After a general version of __weak memory_add_physaddr_to_nid implemented
> > and exported , it is no use exporting twice in arch directory even if
> > e,g, ia64/x86 have their specific version.
> >
> > This is to suppress the modpost warning:
> > WARNING: modpost: vmlinux: 'memory_add_physaddr_to_nid' exported twice.
> > Previous export was in vmlinux
> 
> It's bad form to introduce a warning and then send a follow-up patch to
> fix the warning.  Just fold this patch into patch 1/6.
Thanks, will do

Cheers,
Justin He