[PATCH 3/4] firmware: arm_scmi: Fix scmi_event_header fields typing

Arnd Bergmann arnd at arndb.de
Wed Jul 8 16:38:08 EDT 2020


On Wed, Jul 8, 2020 at 2:24 PM Cristian Marussi
<cristian.marussi at arm.com> wrote:
>
> Drop size_t in favour of fixed size u32 for consistency and shuffle
> around fields definitions to minimize implicit padding.
>
> Signed-off-by: Cristian Marussi <cristian.marussi at arm.com>

As you still have implicit padding at the end, I'd either make
that explicit now, or leave the __packed attribute.

The payld_sz is not actually force to be misaligned with the
reordered layout, which is what's most important.

     Arnd



More information about the linux-arm-kernel mailing list