[RFC PATCH v4 2/2] arm64: tlb: Use the TLBI RANGE feature in arm64
Marc Zyngier
maz at kernel.org
Tue Jul 7 13:43:35 EDT 2020
On 2020-07-07 18:36, Catalin Marinas wrote:
> On Mon, Jun 01, 2020 at 10:47:13PM +0800, Zhenyu Ye wrote:
>> @@ -59,6 +69,47 @@
>> __ta; \
>> })
>>
>> +/*
>> + * __TG defines translation granule of the system, which is decided
>> by
>> + * PAGE_SHIFT. Used by TTL.
>> + * - 4KB : 1
>> + * - 16KB : 2
>> + * - 64KB : 3
>> + */
>> +#define __TG ((PAGE_SHIFT - 12) / 2 + 1)
>
> Nitpick: maybe something like __TLBI_TG to avoid clashes in case
> someone
> else defines a __TG macro.
I have commented on this in the past, and still maintain that this
would be better served by a switch statement similar to what is used
for TTL already (I don't think this magic formula exists in the
ARM ARM).
M.
--
Jazz is not dead. It just smells funny...
More information about the linux-arm-kernel
mailing list