[PATCH 07/10] mfd: ab8500-debugfs: Fix incompatible types in comparison expression issue

Linus Walleij linus.walleij at linaro.org
Tue Jul 7 08:34:21 EDT 2020


On Wed, Jun 24, 2020 at 5:07 PM Lee Jones <lee.jones at linaro.org> wrote:

> Smatch reports:
>
>  drivers/mfd/ab8500-debugfs.c:1804:20: error: incompatible types in comparison expression (different type sizes):
>  drivers/mfd/ab8500-debugfs.c:1804:20:    unsigned int *
>  drivers/mfd/ab8500-debugfs.c:1804:20:    unsigned long *
>
> This is due to mixed types being compared in a min() comparison.  Fix
> this by treating values as signed and casting them to the same type
> as the receiving variable.
>
> Cc: <stable at vger.kernel.org>
> Cc: Linus Walleij <linus.walleij at linaro.org>
> Signed-off-by: Lee Jones <lee.jones at linaro.org>

Reviewed-by: Linus Walleij <linus.walleij at linaro.org>

Yours,
Linus Walleij



More information about the linux-arm-kernel mailing list