[PATCH 23/32] usb: gadget: udc: max3420_udc: Remove set, but never checked variable 'addr'
Lee Jones
lee.jones at linaro.org
Mon Jul 6 09:33:32 EDT 2020
Fixes the following W=1 kernel build warning(s):
drivers/usb/gadget/udc/max3420_udc.c: In function ‘max3420_handle_setup’:
drivers/usb/gadget/udc/max3420_udc.c:626:5: warning: variable ‘addr’ set but not used [-Wunused-but-set-variable]
626 | u8 addr;
| ^~~~
Cc: Felipe Balbi <balbi at kernel.org>
Cc: Jassi Brar <jaswinder.singh at linaro.org>
Cc: Christophe JAILLET <christophe.jaillet at wanadoo.fr>
Signed-off-by: Lee Jones <lee.jones at linaro.org>
---
drivers/usb/gadget/udc/max3420_udc.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/usb/gadget/udc/max3420_udc.c b/drivers/usb/gadget/udc/max3420_udc.c
index 23f33946d80c4..52884bae4af11 100644
--- a/drivers/usb/gadget/udc/max3420_udc.c
+++ b/drivers/usb/gadget/udc/max3420_udc.c
@@ -623,7 +623,6 @@ static void max3420_set_clear_feature(struct max3420_udc *udc)
static void max3420_handle_setup(struct max3420_udc *udc)
{
struct usb_ctrlrequest setup;
- u8 addr;
spi_rd_buf(udc, MAX3420_REG_SUDFIFO, (void *)&setup, 8);
@@ -647,7 +646,7 @@ static void max3420_handle_setup(struct max3420_udc *udc)
USB_TYPE_STANDARD | USB_RECIP_DEVICE)) {
break;
}
- addr = spi_rd8_ack(udc, MAX3420_REG_FNADDR, 1);
+ spi_rd8_ack(udc, MAX3420_REG_FNADDR, 1);
dev_dbg(udc->dev, "Assigned Address=%d\n", udc->setup.wValue);
return;
case USB_REQ_CLEAR_FEATURE:
--
2.25.1
More information about the linux-arm-kernel
mailing list