[PATCH 25/32] usb: early: ehci-dbgp: Remove set but never checked variable 'ret'

Lee Jones lee.jones at linaro.org
Mon Jul 6 09:33:34 EDT 2020


'ret' hasn't  been checked since the driver's inception in 2009.

Fixes the following W=1 kernel build warning(s):

 drivers/usb/early/ehci-dbgp.c: In function ‘early_dbgp_write’:
 drivers/usb/early/ehci-dbgp.c:915:13: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable]
 915 | int chunk, ret;
 | ^~~

Cc: Sumit Garg <sumit.garg at linaro.org>
Cc: Daniel Thompson <daniel.thompson at linaro.org>
Cc: Douglas Anderson <dianders at chromium.org>
Cc: Petr Mladek <pmladek at suse.com>
Cc: "Eric W. Biederman" <ebiederm at xmission.com>
Cc: Yinghai Lu <yhlu.kernel at gmail.com>
Cc: Jason Wessel <jason.wessel at windriver.com>
Signed-off-by: Lee Jones <lee.jones at linaro.org>
---
 drivers/usb/early/ehci-dbgp.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/usb/early/ehci-dbgp.c b/drivers/usb/early/ehci-dbgp.c
index 775cf70cfb3ed..b075dbfad730f 100644
--- a/drivers/usb/early/ehci-dbgp.c
+++ b/drivers/usb/early/ehci-dbgp.c
@@ -912,7 +912,7 @@ int __init early_dbgp_init(char *s)
 
 static void early_dbgp_write(struct console *con, const char *str, u32 n)
 {
-	int chunk, ret;
+	int chunk;
 	char buf[DBGP_MAX_PACKET];
 	int use_cr = 0;
 	u32 cmd, ctrl;
@@ -951,8 +951,8 @@ static void early_dbgp_write(struct console *con, const char *str, u32 n)
 			buf[chunk] = *str;
 		}
 		if (chunk > 0) {
-			ret = dbgp_bulk_write(USB_DEBUG_DEVNUM,
-				      dbgp_endpoint_out, buf, chunk);
+			dbgp_bulk_write(USB_DEBUG_DEVNUM,
+					dbgp_endpoint_out, buf, chunk);
 		}
 	}
 	if (unlikely(reset_run)) {
-- 
2.25.1




More information about the linux-arm-kernel mailing list