[PATCH 19/30] usb: storage: alauda: Remove set but unchecked variable
Lee Jones
lee.jones at linaro.org
Fri Jul 3 13:41:37 EDT 2020
The return value of alauda_get_media_status() hasn't been checked
since the driver's inception back in 2005. If nothing have gone
wrong/been detected until this point, it's probably safe to just
remove the variable.
Fixes the following W=1 kernel build warning(s):
drivers/usb/storage/alauda.c: In function ‘alauda_check_media’:
drivers/usb/storage/alauda.c:456:6: warning: variable ‘rc’ set but not used [-Wunused-but-set-variable]
456 | int rc;
| ^~
Cc: Alan Stern <stern at rowland.harvard.edu>
Cc: Daniel Drake <dsd at gentoo.org>
Cc: usb-storage at lists.one-eyed-alien.net
Signed-off-by: Lee Jones <lee.jones at linaro.org>
---
drivers/usb/storage/alauda.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/usb/storage/alauda.c b/drivers/usb/storage/alauda.c
index ddab2cd3d2e75..20b857e97e60c 100644
--- a/drivers/usb/storage/alauda.c
+++ b/drivers/usb/storage/alauda.c
@@ -453,9 +453,8 @@ static int alauda_check_media(struct us_data *us)
{
struct alauda_info *info = (struct alauda_info *) us->extra;
unsigned char status[2];
- int rc;
- rc = alauda_get_media_status(us, status);
+ alauda_get_media_status(us, status);
/* Check for no media or door open */
if ((status[0] & 0x80) || ((status[0] & 0x1F) == 0x10)
--
2.25.1
More information about the linux-arm-kernel
mailing list