[PATCH v2 0/4] arm64: Fix single-step handling

Will Deacon will at kernel.org
Fri Jul 3 07:49:46 EDT 2020


Hi Luis,

On Fri, Jul 03, 2020 at 07:52:34AM -0300, Luis Machado wrote:
> On 7/2/20 6:26 PM, Will Deacon wrote:
> > This is version two of the patches I previously posted here:
> > 
> >    v1: https://lore.kernel.org/linux-arm-kernel/20200603151033.11512-1-will@kernel.org/
> > 
> > Thanks to Keno for a bunch of helpful feedback on that, which has led to
> > the following major changes for v2:
> > 
> >    - Use pseudo-step traps for both entering a signal handler and exiting a
> >      system call.
> > 
> >    - Document our weird x7 behaviour with PTRACE_SYSCALL.
> > 
> > It has to be said that I'm a bit nervous about these changes. I played
> > around with GDB and things seemed ok, but I would really appreciate it
> > if Luis could run the GDB testsuite with these changes applied.
> 
> Thanks for working on this. I'll need some time to give this a go. I'll let
> you know what the results are.

Brilliant, thank you.

> Do I only need to exercise the AArch64 state? Or would this impact AArch32
> as well?

I doubt AArch32 userspace goes very near PTRACE_SINGLESTEP, as it's not
supported by arch/arm/, so AArch64 testing should be sufficient.

Cheers,

Will



More information about the linux-arm-kernel mailing list