[bug report] firmware: arm_scmi: Add notification callbacks-registration

Dan Carpenter dan.carpenter at oracle.com
Thu Jul 2 07:17:56 EDT 2020


On Wed, Jul 01, 2020 at 01:29:24PM +0100, Cristian Marussi wrote:
> >   1273                  if (!scmi_event_handler_enable_events(hndl)) {
> > 
> > I really don't like that half these functions follow normal kernel error
> > style and half return true/false on failure.  Normally we would want
> > boolean functions to be clear from the name like access_ok() which
> > clearly returns true/false. But I didn't see that it causes any bugs
> > yet.
> 
> Ok I'll convert all the functions to classical 0-Success style dumping
> the booleans. I cannot see in fact any suitable func_ok() style function.

You are a hero.  Thanks!

regards,
dan carpenter




More information about the linux-arm-kernel mailing list