[PATCH v4] cpufreq: brcmstb-avs: fix imbalance of cpufreq policy refcount

qiwuchen55 at gmail.com qiwuchen55 at gmail.com
Sun Jan 19 23:41:28 PST 2020


From: chenqiwu <chenqiwu at xiaomi.com>

brcm_avs_cpufreq_get() calls cpufreq_cpu_get() to get the cpufreq
policy, meanwhile, it also increments the kobject reference count
to mark it busy. However, a corresponding call of cpufreq_cpu_put()
is ignored to decrement the kobject reference count back, which may
lead to a potential stuck risk that the cpuhp thread deadly waits
for dropping of kobject refcount when cpufreq policy free.

With this patch, the cpuhp thread can be easily exercised by
attempting to force an unbind of the CPUfreq driver.

Signed-off-by: chenqiwu <chenqiwu at xiaomi.com>
---
changes in v4:
 - Rewrit commit message.
 - Use cpufreq_cpu_get() and a corresponding cpufreq_cpu_put()
   instead of cpufreq_get_policy() for promoting efficiency.
---
 drivers/cpufreq/brcmstb-avs-cpufreq.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/drivers/cpufreq/brcmstb-avs-cpufreq.c b/drivers/cpufreq/brcmstb-avs-cpufreq.c
index 77b0e5d..0767206 100644
--- a/drivers/cpufreq/brcmstb-avs-cpufreq.c
+++ b/drivers/cpufreq/brcmstb-avs-cpufreq.c
@@ -453,7 +453,13 @@ static bool brcm_avs_is_firmware_loaded(struct private_data *priv)
 static unsigned int brcm_avs_cpufreq_get(unsigned int cpu)
 {
 	struct cpufreq_policy *policy = cpufreq_cpu_get(cpu);
-	struct private_data *priv = policy->driver_data;
+	struct private_data *priv;
+
+	if (!policy)
+		return 0;
+
+	priv = policy->driver_data;
+	cpufreq_cpu_put(policy);
 
 	return brcm_avs_get_frequency(priv->base);
 }
-- 
1.9.1




More information about the linux-arm-kernel mailing list