[EXT] [PATCH] PCI: imx6: Add L1SS support for i.MX8MQ

Andrey Smirnov andrew.smirnov at gmail.com
Thu Jan 16 06:37:09 PST 2020


On Tue, Jan 14, 2020 at 7:26 PM Richard Zhu <hongxing.zhu at nxp.com> wrote:
>
>
> > -----Original Message-----
> > From: Andrey Smirnov <andrew.smirnov at gmail.com>
> > Sent: 2020年1月15日 1:03
> > To: linux-pci at vger.kernel.org
> > Cc: Andrey Smirnov <andrew.smirnov at gmail.com>; Lorenzo Pieralisi
> > <lorenzo.pieralisi at arm.com>; Bjorn Helgaas <bhelgaas at google.com>; Chris
> > Healy <cphealy at gmail.com>; Lucas Stach <l.stach at pengutronix.de>; Richard
> > Zhu <hongxing.zhu at nxp.com>; dl-linux-imx <linux-imx at nxp.com>;
> > linux-arm-kernel at lists.infradead.org; linux-kernel at vger.kernel.org
> > Subject: [EXT] [PATCH] PCI: imx6: Add L1SS support for i.MX8MQ
> >
> > Caution: EXT Email
> >
> > Add code to configure PCI IP block to utilize supported ASPM features.
> >
> > Signed-off-by: Andrey Smirnov <andrew.smirnov at gmail.com>
> [Richard Zhu]  HI Andrey:
> This patch does the regmap to the src region, right?

Indeed.

> How about to add another reset to manipulate the *_OVERRIDE bit.
> Just like the following bits.
>                         resets = <&src IMX8MQ_RESET_PCIEPHY>,
>                                  <&src IMX8MQ_RESET_PCIE_CTRL_APPS_EN>,
>                                  <&src IMX8MQ_RESET_PCIE_CTRL_APPS_TURNOFF>;
>                         reset-names = "pciephy", "apps", "turnoff";
>

Last time I talked to Philipp Zabel (maintainer of reset subsystem) he
made it pretty clear that he though that exposing those PCIe related
bits via reset subsystem (for both imx7 and imx8mq) was a mistake and
going forward he'd like to see only true reset functionality to be
exposed that way. IMX8MQ_PCIE_CTRL_APPS_CLK_REQ is definitely not a
reset line, so the case for adding it to reset driver is even weaker.

Lucas, do you mind sharing your thoughts on this?

Thanks,
Andrey Smirnov



More information about the linux-arm-kernel mailing list