[PATCH v2 3/3] dt-bindings: spi: sunxi: Document new compatible strings

Maxime Ripard mripard at kernel.org
Thu Jan 16 06:23:01 PST 2020


Hi,

On Thu, Jan 16, 2020 at 12:56:54AM +0000, Andre Przywara wrote:
> The Allwinner H6 SPI controller has advanced features over the H3
> version, but remains compatible with it.
> Document the usual "specific", "fallback" compatible string pair.
> Also add the R40 version while at it.
>
> Signed-off-by: Andre Przywara <andre.przywara at arm.com>
> ---
>  .../devicetree/bindings/spi/allwinner,sun6i-a31-spi.yaml     | 12 +++++++++---
>  1 file changed, 9 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/spi/allwinner,sun6i-a31-spi.yaml b/Documentation/devicetree/bindings/spi/allwinner,sun6i-a31-spi.yaml
> index f36c46d236d7..c19dfbe42d90 100644
> --- a/Documentation/devicetree/bindings/spi/allwinner,sun6i-a31-spi.yaml
> +++ b/Documentation/devicetree/bindings/spi/allwinner,sun6i-a31-spi.yaml
> @@ -18,9 +18,15 @@ properties:
>    "#size-cells": true
>
>    compatible:
> -    enum:
> -      - allwinner,sun6i-a31-spi
> -      - allwinner,sun8i-h3-spi
> +    oneOf:
> +      - const: allwinner,sun6i-a31-spi
> +      - const: allwinner,sun8i-h3-spi
> +      - items:
> +          - const: allwinner,sun8i-r40-spi
> +          - const: allwinner,sun8i-h3-spi
> +      - items:
> +          - const: allwinner,sun50i-h6-spi
> +          - const: allwinner,sun8i-h3-spi

Having

oneOf:
  - const: allwinner,sun6i-a31-spi
  - const: allwinner,sun8i-h3-spi
  - items:
    - enum:
      - allwinner,sun8i-r40-spi
      - allwinner,sun50i-h6-spi
    - const: allwinner,sun8i-h3-spi

Will be easier to maintain in the long run

Maxime
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20200116/e4d9cbaa/attachment.sig>


More information about the linux-arm-kernel mailing list