[PATCH 1/3] dt-bindings: timer: Add STM32 Low Power Timer bindings

Benjamin Gaignard benjamin.gaignard at linaro.org
Wed Jan 15 06:45:51 PST 2020


Le mer. 15 janv. 2020 à 15:35, Rob Herring <robh at kernel.org> a écrit :
>
> On Thu, Jan 09, 2020 at 03:53:31PM +0100, Benjamin Gaignard wrote:
> > Document STM32 Low Power bindings.
> >
> > Signed-off-by: Benjamin Gaignard <benjamin.gaignard at st.com>
> > ---
> >  .../bindings/timer/st,stm32-lp-timer.yaml          | 44 ++++++++++++++++++++++
> >  1 file changed, 44 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/timer/st,stm32-lp-timer.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/timer/st,stm32-lp-timer.yaml b/Documentation/devicetree/bindings/timer/st,stm32-lp-timer.yaml
> > new file mode 100644
> > index 000000000000..ca040b96dc47
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/timer/st,stm32-lp-timer.yaml
>
> Use the compatible for the filename.

it will be in v2

>
> > @@ -0,0 +1,44 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/timer/st,stm32-lp-timer.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: STMicroelectronics STM32 Low Power 16 bits timers bindings
> > +
> > +maintainers:
> > +  - Benjamin Gaignard <benjamin.gaignard at st.com>
> > +
> > +properties:
> > +  compatible:
> > +    const: st,stm32-lptimer-clkevent
>
> 'clkevent' is a h/w name? Seems redundant and abusing compatible to
> bind to a specific Linux driver.

No but st,stm32-lptimer compatible is already used for another driver
The hardware block can implement multiple features but not all at the same time
so I try to distinguish them with the compatible.
In this particular case I would like tag it as a clock event driver.

>
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  interrupts:
> > +    maxItems: 1
> > +
> > +  clocks:
> > +    maxItems: 1
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +  - interrupts
> > +  - clocks
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > +  - |
> > +    #include <dt-bindings/interrupt-controller/arm-gic.h>
> > +    #include <dt-bindings/clock/stm32mp1-clks.h>
> > +    clkevent: clkevent at 40009000 {
>
> timer at ...

OK

>
> > +      compatible = "st,stm32-lptimer-clkevent";
> > +      reg = <0x40009000 0x400>;
> > +      clocks = <&rcc LPTIM1_K>;
> > +      interrupts = <GIC_SPI 93 IRQ_TYPE_LEVEL_HIGH>;
> > +    };
> > +
> > +...
> > --
> > 2.15.0
> >
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel



More information about the linux-arm-kernel mailing list