[PATCH v2 09/10] powerpc: Mark archrandom.h functions __must_check

Mark Brown broonie at kernel.org
Fri Jan 10 06:54:21 PST 2020

From: Richard Henderson <richard.henderson at linaro.org>

We must not use the pointer output without validating the
success of the random read.

Acked-by: Michael Ellerman <mpe at ellerman.id.au>
Reviewed-by: Ard Biesheuvel <ardb at kernel.org>
Signed-off-by: Richard Henderson <rth at twiddle.net>
Signed-off-by: Mark Brown <broonie at kernel.org>
 arch/powerpc/include/asm/archrandom.h | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/powerpc/include/asm/archrandom.h b/arch/powerpc/include/asm/archrandom.h
index f0f16b4fc5ea..9a53e29680f4 100644
--- a/arch/powerpc/include/asm/archrandom.h
+++ b/arch/powerpc/include/asm/archrandom.h
@@ -6,17 +6,17 @@
 #include <asm/machdep.h>
-static inline bool arch_get_random_long(unsigned long *v)
+static inline bool __must_check arch_get_random_long(unsigned long *v)
 	return false;
-static inline bool arch_get_random_int(unsigned int *v)
+static inline bool __must_check arch_get_random_int(unsigned int *v)
 	return false;
-static inline bool arch_get_random_seed_long(unsigned long *v)
+static inline bool __must_check arch_get_random_seed_long(unsigned long *v)
 	if (ppc_md.get_random_seed)
 		return ppc_md.get_random_seed(v);
@@ -24,7 +24,7 @@ static inline bool arch_get_random_seed_long(unsigned long *v)
 	return false;
-static inline bool arch_get_random_seed_int(unsigned int *v)
+static inline bool __must_check arch_get_random_seed_int(unsigned int *v)
 	unsigned long val;
 	bool rc;

More information about the linux-arm-kernel mailing list