[PATCH v2 0/2] net: stmmac: remove useless code of phy_mask
zhengdejin5 at gmail.com
Wed Jan 8 05:43:59 PST 2020
On Wed, Jan 08, 2020 at 01:25:21PM +0000, Jose Abreu wrote:
> From: Dejin Zheng <zhengdejin5 at gmail.com>
> Date: Jan/08/2020, 11:26:52 (UTC+00:00)
> > On Wed, Jan 08, 2020 at 07:57:14AM +0000, Jose Abreu wrote:
> > > From: Dejin Zheng <zhengdejin5 at gmail.com>
> > > Date: Jan/08/2020, 07:25:48 (UTC+00:00)
> > >
> > > > Changes since v1:
> > > > 1, add a new commit for remove the useless member phy_mask.
> > >
> > > No, this is not useless. It's an API for developers that need only
> > > certain PHYs to be detected. Please do not remove this.
> > >
> > Hi Jose:
> > Okay, If you think it is a feature that needs to be retained, I will
> > abandon it. since I am a newbie, after that, Do I need to update the
> > other commit in this patchset for patch v3? Thanks!
> Your first commit (1/2) looks okay so you can submit that stand-alone in
> my opinion.
Jose, thanks for your suggestions, You are so nice! I will do it.
> Jose Miguel Abreu
More information about the linux-arm-kernel