[PATCH 05/13] mailbox: bcm2835: convert to devm_platform_ioremap_resource

Nicolas Saenz Julienne nsaenzjulienne at suse.de
Tue Jan 7 02:57:07 PST 2020


On Sat, 2019-12-28 at 18:35 +0000, Yangtao Li wrote:
> Use devm_platform_ioremap_resource() to simplify code.
> 
> Signed-off-by: Yangtao Li <tiny.windzz at gmail.com>
> ---

Reviewed-by: Nicolas Saenz Julienne <nsaenzjulienne at suse.de>

Thanks!

>  drivers/mailbox/bcm2835-mailbox.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/mailbox/bcm2835-mailbox.c b/drivers/mailbox/bcm2835-
> mailbox.c
> index 39761d190545..79f93c9c7682 100644
> --- a/drivers/mailbox/bcm2835-mailbox.c
> +++ b/drivers/mailbox/bcm2835-mailbox.c
> @@ -137,7 +137,6 @@ static int bcm2835_mbox_probe(struct platform_device
> *pdev)
>  {
>  	struct device *dev = &pdev->dev;
>  	int ret = 0;
> -	struct resource *iomem;
>  	struct bcm2835_mbox *mbox;
>  
>  	mbox = devm_kzalloc(dev, sizeof(*mbox), GFP_KERNEL);
> @@ -153,8 +152,7 @@ static int bcm2835_mbox_probe(struct platform_device
> *pdev)
>  		return -ENODEV;
>  	}
>  
> -	iomem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	mbox->regs = devm_ioremap_resource(&pdev->dev, iomem);
> +	mbox->regs = devm_platform_ioremap_resource(pdev, 0);
>  	if (IS_ERR(mbox->regs)) {
>  		ret = PTR_ERR(mbox->regs);
>  		dev_err(&pdev->dev, "Failed to remap mailbox regs: %d\n", ret);

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: This is a digitally signed message part
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20200107/e9c0c067/attachment.sig>


More information about the linux-arm-kernel mailing list