[PATCH 0/5] firmware: xilinx: Add xilinx specific sysfs interface

Sudeep Holla sudeep.holla at arm.com
Fri Jan 3 03:31:51 PST 2020


On Thu, Jan 02, 2020 at 09:01:58PM +0000, Jolly Shah wrote:
> Hi Sudeep,
>
> Thanks for the review.
>
> > -----Original Message-----
> > From: Sudeep Holla <sudeep.holla at arm.com>
> > Sent: Wednesday, December 18, 2019 6:46 AM
> > To: Jolly Shah <JOLLYS at xilinx.com>
> > Cc: ard.biesheuvel at linaro.org; mingo at kernel.org;
> > gregkh at linuxfoundation.org; matt at codeblueprint.co.uk;
> > hkallweit1 at gmail.com; keescook at chromium.org;
> > dmitry.torokhov at gmail.com; Michal Simek <michals at xilinx.com>; Rajan Vaja
> > <RAJANV at xilinx.com>; linux-arm-kernel at lists.infradead.org; linux-
> > kernel at vger.kernel.org; Sudeep Holla <sudeep.holla at arm.com>
> > Subject: Re: [PATCH 0/5] firmware: xilinx: Add xilinx specific sysfs interface
> >
> > On Wed, Dec 04, 2019 at 03:29:14PM -0800, Jolly Shah wrote:
> > > This patch series adds xilinx specific sysfs interface for below
> > > purposes:
> > > - Register access
> > > - Set shutdown scope
> > > - Set boot health status bit
> >
> > This series defeats the whole abstraction EEMI provides. By providing
> > direct register accesses, you are allowing user-space to do whatever it
> > wants. I had NACKed this idea before. Has anything changed ?
> >
>
> Firmware checks for allowed accesses only and rejects rest.
>

If that is always the case, why not abstract them and remove this direct
register access completely. It must go or we must remove EEMI abstraction
and just provide direct register access to the entire space. I really
don't like this mix-n-match approach here.

> > If you need it for testing firmware, better put them in debugfs which is
> > off on production builds.
>
> Sure. Will reanalyze use cases and move to debugfs only if that suffices.
>

Thanks.

--
Regards,
Sudeep



More information about the linux-arm-kernel mailing list