[PATCH v2 2/3] pwm: rockchip: Eliminate potential race condition when probing

Simon South simon at simonsouth.net
Tue Dec 22 11:26:59 EST 2020

Uwe Kleine-König <u.kleine-koenig at pengutronix.de> writes:
> I wonder if the commit log should be more detailed about this, after
> reading it I thought the effect of the bug would be that the PWM stops
> even though it should oscillate.

Your understanding is correct; this was the result of confusion on my
part. I'll write a new commit message.

>> Also refactor the code slightly to eliminate goto targets as the
>> error handlers no longer share any recovery steps.
> This however makes it hard to review the patch. Maybe this refactoring
> can be split out?

I'll give this another shot, too.

Simon South
simon at simonsouth.net

More information about the linux-arm-kernel mailing list