[PATCH v8 1/4] dt-bindings: soc: imx8m: add DT Binding doc for soc unique ID

[Rob Herring]

On Mon, Dec 21, 2020 at 2:20 AM Alice Guo (OSS) <alice.guo at oss.nxp.com> wrote:
>
>
>
> > -----Original Message-----
> > From: Rob Herring <robh+dt at kernel.org>
> > Sent: 2020年12月18日 22:00
> > To: Alice Guo (OSS) <alice.guo at oss.nxp.com>
> > Cc: Krzysztof Kozlowski <krzk at kernel.org>; shawnguo at kernel.org;
> > s.hauer at pengutronix.de; kernel at pengutronix.de; festevam at gmail.com;
> > devicetree at vger.kernel.org; linux-arm-kernel at lists.infradead.org;
> > linux-kernel at vger.kernel.org; dl-linux-imx <linux-imx at nxp.com>
> > Subject: Re: [PATCH v8 1/4] dt-bindings: soc: imx8m: add DT Binding doc for soc
> > unique ID
> >
> > On Fri, Dec 18, 2020 at 4:14 AM Alice Guo (OSS) <alice.guo at oss.nxp.com>
> > wrote:
> > >
> > >
> > >
> > > > -----Original Message-----
> > > > From: Krzysztof Kozlowski <krzk at kernel.org>
> > > > Sent: 2020年12月18日 17:37
> > > > To: Alice Guo (OSS) <alice.guo at oss.nxp.com>
> > > > Cc: robh+dt at kernel.org; shawnguo at kernel.org; s.hauer at pengutronix.de;
> > > > kernel at pengutronix.de; festevam at gmail.com;
> > > > devicetree at vger.kernel.org; linux-arm-kernel at lists.infradead.org;
> > > > linux-kernel at vger.kernel.org; dl-linux-imx <linux-imx at nxp.com>
> > > > Subject: Re: [PATCH v8 1/4] dt-bindings: soc: imx8m: add DT Binding
> > > > doc for soc unique ID
> > > >
> > > > On Fri, Dec 18, 2020 at 09:05:00AM +0000, Alice Guo (OSS) wrote:
> > > >  > > +    required:
> > > > > > > +      - compatible
> > > > > > > +      - nvmem-cells
> > > > > > > +      - nvmem-cell-names
> > > > > > > +
> > > > > > > +additionalProperties: true
> > > > > >
> > > > > > Don't leave comments unresolved (or resolve them against review
> > > > > > without discussion). Rob asked for changing it. The same as with
> > > > > > all schemas - you need to describe the missing properties.
> > > > > >
> > > > > > Best regards,
> > > > > > Krzysztof
> > > > >
> > > > > Hi,
> > > > > Thank you for your advice. I replied to him and let him know I
> > > > > remained here
> > > > unchanged. There will be errors according to his suggestion.
> > > >
> > > > Then the solution is to correct the errors - describe missing
> > > > properties
> > > > - instead of ignoring the suggestion and making a resubmit right away.
> > > >
> > > > Best regards,
> > > > Krzysztof
> > >
> > > Hi,
> > > I am sorry I do not DT Binding doc very well.
> > >
> > > I checked the usage of patternProperties and additionalProperties in
> > https://json-schema.org/understanding-json-schema/reference/object.html.
> > > I noticed a sentence on the website: " If additionalProperties is a
> > > boolean and set to false, no additional properties will be allowed.", so I think
> > that if additionalProperties is a boolean and set to true, additional properties
> > will be allowed. Letting here unchanged is my solution to correct the errors.
> > > I am not sure, I asked Rob for advice on the v6 by email, but he didn't reply to
> > me, so I made a resubmit.
> >
> > You waited an hour and I was sleeping! Waiting means waiting a week.
> >
> > You need to add '#address-cells' and '#size-cells'.
> >
> > Rob
> Hi, Rob
>
> Can change to the following code?
> When uses "additionalProperties: type: object", need to add model, compatible, interrupt-parent, #address-cells and #size-cells.
> There will be error with adding interrupt-parent because "dt-bindings: remove 'interrupt-parent' from bindings".

You are at the wrong level. It's 'additionalProperties' for the soc
node, not the root. See below.

>
> # SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> %YAML 1.2
> ---
> $id: http://devicetree.org/schemas/soc/imx/imx8m-soc.yaml#
> $schema: http://devicetree.org/meta-schemas/core.yaml#
>
> title: NXP i.MX8M Series SoC
>
> maintainers:
>   - Alice Guo <alice.guo at nxp.com>
>
> description: |
>   NXP i.MX8M series SoCs contain fuse entries from which SoC Unique ID can be
>   obtained.
>
> properties:
>   $nodename:
>     const: '/'
>
>   compatible:
>     contains:
>       enum:
>         - fsl,imx8mm
>         - fsl,imx8mn
>         - fsl,imx8mp
>         - fsl,imx8mq
>
>   "#address-cells":
>     const: 2
>   "#size-cells":
>     const: 2
>
> patternProperties:
>   "^soc@[0-9a-f]+$":
>     type: object
>     properties:
>       compatible:
>         items:
>           - enum:
>               - fsl,imx8mm-soc
>               - fsl,imx8mn-soc
>               - fsl,imx8mp-soc
>               - fsl,imx8mq-soc
>           - const: simple-bus
>
>       nvmem-cells:
>         maxItems: 1
>         description: Phandle to the SOC Unique ID provided by a nvmem node
>
>       nvmem-cells-names:
>         const: soc_unique_id
>
>     required:
>       - compatible
>       - nvmem-cells
>       - nvmem-cell-names
>

      additionalProperties:
        type: object

> additionalProperties: true

And keep this as-is.

> ...
>
> Best regards,
> Alice
>
>