[PATCH 4/8] remoteproc: imx_rproc: use devm_ioremap

Peng Fan (OSS) peng.fan at oss.nxp.com
Mon Dec 21 05:06:28 EST 2020

From: Peng Fan <peng.fan at nxp.com>

We might need to map an region multiple times, becaue the region might
be shared between remote processors, such i.MX8QM with dual M4 cores.
So use devm_ioremap, not devm_ioremap_resource.

Reviewed-by: Oleksij Rempel <o.rempel at pengutronix.de>
Reviewed-by: Richard Zhu <hongxing.zhu at nxp.com>
Signed-off-by: Peng Fan <peng.fan at nxp.com>


 drivers/remoteproc/imx_rproc.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c
index fab772b02c9f..3915c7f5ac47 100644
--- a/drivers/remoteproc/imx_rproc.c
+++ b/drivers/remoteproc/imx_rproc.c
@@ -296,7 +296,8 @@ static int imx_rproc_addr_init(struct imx_rproc *priv,
 		if (b >= IMX7D_RPROC_MEM_MAX)
-		priv->mem[b].cpu_addr = devm_ioremap_resource(&pdev->dev, &res);
+		/* Not use resource version, because we might share region */
+		priv->mem[b].cpu_addr = devm_ioremap(&pdev->dev, res.start, resource_size(&res));
 		if (IS_ERR(priv->mem[b].cpu_addr)) {
 			dev_err(dev, "failed to remap %pr \n", &res);
 			err = PTR_ERR(priv->mem[b].cpu_addr);

More information about the linux-arm-kernel mailing list