[PATCH 9/9] mfd: sec-irq: Do not enforce (incorrect) interrupt trigger type
krzk at kernel.org
Mon Dec 21 02:55:00 EST 2020
On Mon, Dec 21, 2020 at 08:36:02AM +0100, Marek Szyprowski wrote:
> Hi Krzysztof,
> On 18.12.2020 15:22, Krzysztof Kozlowski wrote:
> > On Fri, Dec 18, 2020 at 02:25:39PM +0100, Marek Szyprowski wrote:
> >> On 10.12.2020 22:29, Krzysztof Kozlowski wrote:
> >>> Interrupt line can be configured on different hardware in different way,
> >>> even inverted. Therefore driver should not enforce specific trigger
> >>> type - edge falling - but instead rely on Devicetree to configure it.
> >>> The Samsung PMIC drivers are used only on Devicetree boards.
> >>> Additionally, the PMIC datasheets describe the interrupt line as active
> >>> low with a requirement of acknowledge from the CPU therefore the edge
> >>> falling is not correct.
> >>> Signed-off-by: Krzysztof Kozlowski <krzk at kernel.org>
> >> Tested-by: Marek Szyprowski <m.szyprowski at samsung.com>
> >> It looks that this together with DTS change fixes RTC alarm failure that
> >> I've observed from time to time on TM2e board!
> > Great! I'll add this to the commit msg.
> > Thanks for testing.
> BTW, while playing with this, maybe it would make sense to fix the
> reported interrupt type for the PMIC sub-interrupts:
> # grep s2mps /proc/interrupts
> 120: 0 gpa0 7 Level s2mps13
> 121: 0 s2mps13 10 Edge rtc-alarm0
I also spotted this. It's a virtual interrupt and I am not sure whether
we can actually configure it when the hardware does not allow to set the
type (the regmap_irq_type requires register offsets).
More information about the linux-arm-kernel