[EXT] Re: [PATCH v2 3/4] arm64: dts: cn913x: add device trees for topology B boards

[Kostya Porotchkin]

Hello, Andrew,
Thank you for review!

> -----Original Message-----
> From: Andrew Lunn <andrew at lunn.ch>
> Sent: Thursday, December 17, 2020 17:41
> To: Kostya Porotchkin <kostap at marvell.com>
> Cc: linux-arm-kernel at lists.infradead.org; tmn505 at gmail.com;
> jaz at semihalf.com; gregory.clement at bootlin.com; Nadav Haklai
> <nadavh at marvell.com>; robh+dt at kernel.org; Stefan Chulski
> <stefanc at marvell.com>; mw at semihalf.com; Ben Peled
> <bpeled at marvell.com>; sebastian.hesselbarth at gmail.com
> Subject: [EXT] Re: [PATCH v2 3/4] arm64: dts: cn913x: add device trees for
> topology B boards
> 
> External Email
> 
> ----------------------------------------------------------------------
> > diff --git a/arch/arm64/boot/dts/marvell/Makefile
> > b/arch/arm64/boot/dts/marvell/Makefile
> > index 3e5f2e7a040c..d9b924a63d89 100644
> > --- a/arch/arm64/boot/dts/marvell/Makefile
> > +++ b/arch/arm64/boot/dts/marvell/Makefile
> > @@ -13,6 +13,9 @@ dtb-$(CONFIG_ARCH_MVEBU) += armada-8040-
> db.dtb
> >  dtb-$(CONFIG_ARCH_MVEBU) += armada-8040-mcbin.dtb
> >  dtb-$(CONFIG_ARCH_MVEBU) += armada-8040-mcbin-singleshot.dtb
> >  dtb-$(CONFIG_ARCH_MVEBU) += armada-8080-db.dtb
> > -dtb-$(CONFIG_ARCH_MVEBU) += cn9130-db.dtb
> > -dtb-$(CONFIG_ARCH_MVEBU) += cn9131-db.dtb
> > -dtb-$(CONFIG_ARCH_MVEBU) += cn9132-db.dtb
> > +dtb-$(CONFIG_ARCH_MVEBU) += cn9130-db-A.dtb
> > +dtb-$(CONFIG_ARCH_MVEBU) += cn9130-db-B.dtb
> > +dtb-$(CONFIG_ARCH_MVEBU) += cn9131-db-A.dtb
> > +dtb-$(CONFIG_ARCH_MVEBU) += cn9131-db-B.dtb
> > +dtb-$(CONFIG_ARCH_MVEBU) += cn9132-db-A.dtb
> > +dtb-$(CONFIG_ARCH_MVEBU) += cn9132-db-B.dtb
> 
> Are the filenames consider ABI? I wonder if cn9130-db A should continue to
> be called cn9130-db.dtb? Are bootloaders and image installers going to break
> because the filename changed?
[KP] I wanted to 
1) make the DTS naming match the current SDK code
2) avoid similarity between DTS and DTSI names
I do not expect wide usage of DB platforms at this time,  I expect the CRB to be more popular due to its size and price.
Do you think it may cause a problem?

Kosta
> 
> The rest of the changes look fine.
> 
>     Andrew