[PATCH v2 1/3] media: i2c: imx219: add support for specifying clock-frequencies

Krzysztof Kozlowski krzk at kernel.org
Fri Dec 18 04:59:48 EST 2020

On Thu, 10 Dec 2020 at 21:56, Michael Srba <Michael.Srba at seznam.cz> wrote:
> Hi,
> sorry for late reply.
> I copied this approach from looking at other camera sensor drivers,
> and it seemed less "ugly" to me than using assigned-rates (I will be
> upstreaming required dts changes for Samsung Galaxy A3 (2015), so the
> dts feeling "proper" is important to me).

The clean solution is the assigned-clock properties. It's handled by
the core. Duplicating the same feature to every driver is not
"cleaner", but the opposite - ugly one.

> I however am not qualified to make that decision, so if you believe
> that the assigned-rates approach is cleaner and more suitable for mainline,
> I will try to adjust my internal filter for what is "more proper" :)

More proper is handling stuff in the core, not implementing the same
thing in every driver, one more time. Therefore, the assigned-clock

Best regards,
Best regards,

More information about the linux-arm-kernel mailing list