[PATCH] net: allwinner: Fix some resources leak in the error handling path of the probe and in the remove function

Christophe JAILLET christophe.jaillet at wanadoo.fr
Tue Dec 15 13:18:48 EST 2020

Le 15/12/2020 à 12:37, Maxime Ripard a écrit :
> On Tue, Dec 15, 2020 at 12:11:53PM +0300, Dan Carpenter wrote:
>> On Tue, Dec 15, 2020 at 09:56:55AM +0100, Maxime Ripard wrote:
>>> Hi,
>>> On Mon, Dec 14, 2020 at 09:21:17PM +0100, Christophe JAILLET wrote:
>>>> 'irq_of_parse_and_map()' should be balanced by a corresponding
>>>> 'irq_dispose_mapping()' call. Otherwise, there is some resources leaks.
>>> Do you have a source to back that? It's not clear at all from the
>>> documentation for those functions, and couldn't find any user calling it
>>> from the ten-or-so random picks I took.
>> It looks like irq_create_of_mapping() needs to be freed with
>> irq_dispose_mapping() so this is correct.
> The doc should be updated first to make that clear then, otherwise we're
> going to fix one user while multiples will have poped up
> Maxime


as Dan explained, I think that 'irq_dispose_mapping()' is needed because 
of the 'irq_create_of_mapping()" within 'irq_of_parse_and_map()'.

As you suggest, I'll propose a doc update to make it clear and more 
future proof.


More information about the linux-arm-kernel mailing list