[PATCH v1] ARM: tegra: Fix misplaced tegra_uart_config in decompressor

Dmitry Osipenko digetx at gmail.com
Tue Dec 15 11:53:25 EST 2020

15.12.2020 19:40, Florian Fainelli пишет:
> On 12/15/2020 8:17 AM, Dmitry Osipenko wrote:
>> 15.12.2020 19:04, Florian Fainelli пишет:
>>> On 12/15/2020 5:52 AM, Dmitry Osipenko wrote:
>>>> The tegra_uart_config of the DEBUG_LL code is now placed right at the
>>>> start of the .text section after commit which enabled debug output in the
>>>> decompressor. Tegra devices are not booting anymore if DEBUG_LL is enabled
>>>> since tegra_uart_config data is executes as a code. Fix the misplaced
>>>> tegra_uart_config storage by embedding it into the code.
>>>> Cc: stable at vger.kernel.org
>>>> Fixes: 2596a72d3384 ("ARM: 9009/1: uncompress: Enable debug in head.S")
>>>> Signed-off-by: Dmitry Osipenko <digetx at gmail.com>
>>>> ---
>>>>  arch/arm/include/debug/tegra.S | 54 +++++++++++++++++-----------------
>>>>  1 file changed, 27 insertions(+), 27 deletions(-)
>>> Looks like arch/arm/include/debug/brcmstb.S would need the same
>>> treatment since the implementation was copied from tegra.S.
>> Good catch, will you be able to test the brcm and make a patch?
> Yes, absolutely, building a kernel to test right now.

Thank you.

BTW, I noticed that the problem is more visible on a thumb2 kernel
build, i.e. you should get a more reliable hang on boot. On a non-thumb2
kernel the hanging behaviour seems depends on a device / bootloader. I
haven't tried to figure out what exactly makes the difference, perhaps
it should be a memory layout / state.

More information about the linux-arm-kernel mailing list