mmc: atmel-mci: Reduce scope for the variable “slot” in atmci_request_end()
joe at perches.com
Sat Dec 12 13:48:55 EST 2020
On Sat, 2020-12-12 at 14:17 +0100, Alexandre Belloni wrote:
> On 12/12/2020 01:16:39-0800, Joe Perches wrote:
> > In this case Alexandre it seems true, but in the generic case
> > it may be false. It may depend on stack size and location.
> > For instance, with large structs declared either at the top
> > of a function or in separate branches within the function:
> I think you realize your example is way more complicated than
> initializing basic type variable to 0 or NULL which has probably been
> optimized forever.
Markus does a lot of what most (or perhaps some) consider thoughtless.
A generic point might be maximizing the local scope of declarations.
Maximizing the local scope can make reading easier as the type of an
automatic used for a temporary purpose can be found closer to the code
that uses it. This is especially true for long line-count functions.
IMO: it's a reasonable goal though in this instance perhaps unnecessary.
More information about the linux-arm-kernel