Re: mmc: atmel-mci: Reduce scope for the variable “slot” in atmci_request_end()

Markus Elfring Markus.Elfring at web.de
Fri Dec 11 01:34:41 EST 2020


>> How do you think about a patch like “staging: speakup: remove redundant initialization
>> of pointer p_key” for comparison?
>> https://lore.kernel.org/patchwork/patch/1199128/
>> https://lore.kernel.org/driverdev-devel/20200223153954.420731-1-colin.king@canonical.com/
>>
>> Would you tolerate to omit the initialisation for the variable “slot”?
>
> If you were able to provide one good technical reason.

I find that the positions of variable definitions (and similar assignments) influence
the generation of executable code.


How do you think about another bit of background information?

Example:
[PATCH v3 2/3] gianfar: Delete unnecessary variable initialisations in gfar_ethflow_to_filer_table()
https://lore.kernel.org/patchwork/patch/635859/#821314
https://lore.kernel.org/lkml/20160115121510.GJ4764@mwanda/

Regards,
Markus



More information about the linux-arm-kernel mailing list