Re: [PATCH] mmc: atmel-mci: Reduce scope for the variable “slot” in atmci_request_end()

[Markus Elfring]

>> Can the extra null pointer initialisation trigger a source code analysis warning
>> like “Addresses-Coverity: ("Unused value")” for this function implementation?
>>
>
> Did you check, does it? It doesn't.
>
> Are you wasting maintainer and reviewer's time? Yes you are.

How do you think about a patch like “staging: speakup: remove redundant initialization
of pointer p_key” for comparison?
https://lore.kernel.org/patchwork/patch/1199128/
https://lore.kernel.org/driverdev-devel/20200223153954.420731-1-colin.king@canonical.com/

Would you tolerate to omit the initialisation for the variable “slot”?

Regards,
Markus