[PATCH v3] pwm: bcm2835: Support apply function for atomic configuration

Uwe Kleine-König u.kleine-koenig at pengutronix.de
Thu Dec 10 06:43:30 EST 2020


On Tue, Dec 08, 2020 at 11:01:45PM +0100, Lino Sanfilippo wrote:
> Use the newer .apply function of pwm_ops instead of .config, .enable,
> .disable and .set_polarity. This guarantees atomic changes of the pwm
> controller configuration. It also reduces the size of the driver.
> Since now period is a 64 bit value, add an extra check to reject periods
> that exceed the possible max value for the 32 bit register.
> This has been tested on a Raspberry PI 4.
> Signed-off-by: Lino Sanfilippo <LinoSanfilippo at gmx.de>

Reviewed-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>

Side note: I'm a bit surprised about the output of

	b4 diff 1607464905-16630-1-git-send-email-LinoSanfilippo at gmx.de

This is probably due to the fact that compared to v3 you also rebased.
Still the diff is quite big.

Best regards and thanks for your patch

Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20201210/d7af3c06/attachment.sig>

More information about the linux-arm-kernel mailing list