[PATCH] perf arm pmu: fix build error on MUSL libc
chanho61.park at samsung.com
Tue Dec 8 04:54:58 EST 2020
Hi Namhyung and Jiri,
> -----Original Message-----
> From: Jiri Olsa <jolsa at redhat.com>
> Sent: Monday, December 7, 2020 10:29 PM
> To: Namhyung Kim <namhyung at kernel.org>
> Cc: Chanho Park <chanho61.park at samsung.com>; Will Deacon
<will at kernel.org>;
> Chanho Park <parkch98 at gmail.com>; mathieu.poirier at linaro.org;
> suzuki.poulose at arm.com; coresight at lists.linaro.org; linux-arm-
> kernel at lists.infradead.org; linux-kernel <linux-kernel at vger.kernel.org>;
> Mike Leach <mike.leach at linaro.org>; Leo Yan <leo.yan at linaro.org>; John
> Garry <john.garry at huawei.com>; Peter Zijlstra <peterz at infradead.org>; Ingo
> Molnar <mingo at redhat.com>; Arnaldo Carvalho de Melo <acme at kernel.org>;
> Mark Rutland <mark.rutland at arm.com>; Khem Raj <raj.khem at gmail.com>
> Subject: Re: [PATCH] perf arm pmu: fix build error on MUSL libc
> On Mon, Dec 07, 2020 at 09:31:06PM +0900, Namhyung Kim wrote:
> > Hi Chanho,
> > On Mon, Dec 7, 2020 at 8:58 PM Chanho Park <chanho61.park at samsung.com>
> > >
> > > Hi Will,
> > >
> > > > Looks like other files just include this unconditionally, but have
> > > > a comment explaining why. See util/branch.h and util/event.h.
> > > > Maybe we should do the same for util/pmu.h, which is already
> included here?
> > >
> > > I found below files which perf includes <linux/perf_event.h>.
> > > Instead of doing same for all, we'd better put this only for
> > > tools/include/uapi/linux/perf_event.h.
> > It's a copy of the kernel header, I'm not sure we want to add something
> right, we want to copy that directly from kernel uapi so let's not do any
> changes in here
I tried to modify it from include/uapi/linux/perf_event.h but it didn't
work. And then, I found perf tool tried to refer the header from
tools/include/ directory. I should go include/uapi first and sync the change
to tools/ directory. I'll re-spin this patch.
More information about the linux-arm-kernel