[PATCH] arm64: dts: imx8mn: Fix duplicate node name
Krzysztof Kozlowski
krzk at kernel.org
Mon Dec 7 08:21:40 EST 2020
On Mon, Dec 07, 2020 at 02:53:24PM +0800, Shengjiu Wang wrote:
> Error log:
> sysfs: cannot create duplicate filename '/bus/platform/devices/30000000.bus'
>
> The spba bus name is duplicate with aips bus name.
> Refine spba bus name to fix this issue.
>
> Fixes: 970406eaef3a ("arm64: dts: imx8mn: Enable Asynchronous Sample Rate Converter")
> Signed-off-by: Shengjiu Wang <shengjiu.wang at nxp.com>
> ---
> arch/arm64/boot/dts/freescale/imx8mn.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mn.dtsi b/arch/arm64/boot/dts/freescale/imx8mn.dtsi
> index fd669c0f3fe5..30762eb4f0a7 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mn.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mn.dtsi
> @@ -246,7 +246,7 @@ aips1: bus at 30000000 {
> #size-cells = <1>;
> ranges;
>
> - spba: bus at 30000000 {
> + spba: spba-bus at 30000000 {
The proper node name is "bus" so basically you introduce wrong name to
other problem. Introducing wrong names at least requires a comment.
However the actual problem here is not in node names but in addresses:
aips1: bus at 30000000 {
spba: bus at 30000000 {
You have to devices with the same unit address. How do you share the
address space?
I think this should be rather fixed.
Best regards,
Krzysztof
> compatible = "fsl,spba-bus", "simple-bus";
> #address-cells = <1>;
> #size-cells = <1>;
> --
> 2.27.0
>
More information about the linux-arm-kernel
mailing list