[PATCH v2] pwm: bcm2835: Support apply function for atomic configuration

Lino Sanfilippo LinoSanfilippo at gmx.de
Fri Dec 4 18:25:41 EST 2020


Hi,

On 04.12.20 at 12:21, Uwe Kleine-König wrote:

>
> I'd make value an unsigned long long and check for > 0xffffffff instead
> of repeating the (expensive) division. (Hmm, maybe the compiler is smart
> enough to not actually repeat it, but still.)
I also prefer unsigned long long over u64 since thats what DIV_ROUND_CLOSEST_ULL returns.
However since we have the constant U32_MAX for 0xffffffff we should use that.

Thanks,
Lino




More information about the linux-arm-kernel mailing list