[PATCH] ARM: sa11111: make sa1111 bus's remove callback return void

Uwe Kleine-König u.kleine-koenig at pengutronix.de
Fri Dec 4 15:09:27 EST 2020


Hey Greg,

On Fri, Dec 04, 2020 at 03:58:17PM +0100, Greg Kroah-Hartman wrote:
> On Thu, Nov 26, 2020 at 12:47:24PM +0100, Uwe Kleine-König wrote:
> > The driver core ignores the return value of struct device_driver::remove
> > because there is only little that can be done. To simplify the quest to
> > make this function return void, let struct sa1111_driver::remove return
> > void, too. All users already unconditionally return 0, this commit makes
> > it obvious that returning an error code is a bad idea and ensures future
> > users behave accordingly.
> > 
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>
> 
> Reviewed-by: Greg Kroah-Hartman <gregkh at linuxfoundation.org>

Thanks, can I interpret this also as an Ack to take the change affecting
drivers/usb via Russell's tree?

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20201204/9b809ec1/attachment.sig>


More information about the linux-arm-kernel mailing list