[PATCH v7 3/3] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver
kuba at kernel.org
Wed Dec 2 12:18:52 EST 2020
On Wed, 02 Dec 2020 11:46:28 +0100 Lukasz Stelmach wrote:
> >> + status = netif_rx(skb);
> > If I'm reading things right this is in process context, so netif_rx_ni()
> Is it? The stack looks as follows
> and ax88796c_work() is a scheduled in the system_wq.
Are you asking if work queue gets run in process context? It does.
> >> + if (status != NET_RX_SUCCESS)
> >> + netif_info(ax_local, rx_err, ndev,
> >> + "netif_rx status %d\n", status);
> > Again, it's inadvisable to put per packet prints without any rate
> > limiting in the data path.
> Even if limmited by the msglvl flag, which is off by default?
I'd err on the side of caution, but up to you.
More information about the linux-arm-kernel