[PATCHv4 12/17] arm64: uaccess: split user/kernel routines

Mark Rutland mark.rutland at arm.com
Wed Dec 2 07:19:50 EST 2020


On Tue, Dec 01, 2020 at 11:03:23AM +0000, Mark Rutland wrote:
> On Thu, Nov 26, 2020 at 06:42:24PM +0000, James Morse wrote:
> > On 13/11/2020 12:49, Mark Rutland wrote:
 
> > > +#define __get_kernel_nofault(dst, src, type, err_label)			\
> > > +do {									\
> > > +	int __gkn_err = 0;						\
> > > +									\
> > > +	__raw_get_mem("ldr", *((type *)(dst)),				\
> > > +		      (__force type __user *)(src), __gkn_err);		\
> > 
> > Is the __user needed as you moved __chk_user_ptr() out of __raw_get_mem() in the previous
> > patch?
> 
> You're right; the __user portion can go as neither __raw_get_mem() or
> __get_mem_asm() needs that. Likewise for __put_kernel_nofault(),
> __raw_put_mem(), and __put_mem_asm().
> 
> I've removed those.
> 
> > (your branch on kernel.org does something different here, not sure if its ahead or behind v4)
> 
> AFAICT this portion of the patch is up-to-date with what's on
> kernel.org. I might have pushed that out-of-order with posting the
> series -- does this look the same now, or am I missing something?

So I can update the branch, I've tagged the version I was referring to
above as arm64-set-fs-removal-20201113. The HEAD commit was:

  c765cd9bec3bfac8 ("arm64: uaccess: remove vestigal UAO support")

Thanks,
Mark.



More information about the linux-arm-kernel mailing list