[PATCH v5] drm/bridge: add it6505 driver

Sam Ravnborg sam at ravnborg.org
Tue Dec 1 04:59:30 EST 2020

Hi Allen.
On Tue, Dec 01, 2020 at 01:44:41PM +0800, allen wrote:
> This adds support for the iTE IT6505.
> This device can convert DPI signal to DP output.
> From: Allen Chen <allen.chen at ite.com.tw>
> Signed-off-by: Jitao Shi <jitao.shi at mediatek.com>
> Signed-off-by: Pi-Hsun Shih <pihsun at chromium.org>
> Signed-off-by: Yilun Lin <yllin at google.com>
> Signed-off-by: Hermes Wu <hermes.wu at ite.com.tw>
> Signed-off-by: Allen Chen <allen.chen at ite.com.tw>

I recall I provided the same comment as last time, but may remember

New bridge drivers shall support that connector creation is optional.
This driver does not do that - see following code snippet:

+       if (flags & DRM_BRIDGE_ATTACH_NO_CONNECTOR) {
+               DRM_ERROR("Fix bridge driver to make connector optional!");
+               return -EINVAL;
+       }

I did not check, but likely the drive needs to implment some of the
connector hooks too. (detect, get_edid, etc).

Please include a changelog too - it can be very hard to remember what
feedback was provided when one reviews several patches/week.


More information about the linux-arm-kernel mailing list