[PATCH v3 0/8] Add Toshiba Visconti ARM64 Platform support

[Nobuhiro Iwamatsu]

Hi,

Thanks for your review and comment.

On Mon, Aug 31, 2020 at 11:19:02AM +0200, Arnd Bergmann wrote:
> On Mon, Aug 31, 2020 at 10:10 AM Nobuhiro Iwamatsu
> <nobuhiro1.iwamatsu at toshiba.co.jp> wrote:
> >
> > Visconti is a series of Toshiba's SoCs targeting image processing
> > applications[0]. These set of patches adds support for Visconti5 a Arm
> > v8 based SoC.
> >
> > The series add minimal support for the Visconti5 SoC and the TMPV7708 RM
> > main board. Peripherals such as UART, SPI, I2c and timer use Arm's
> > IP and work with the existing kernel drivers in the tree. The series
> > includes a pinctrl driver to select appropriate functions on the pins.
> 
> The arch/arm64 series looks all reasonable to me, nice work!
> 
> Once the review from the DT and pinctrl maintainers is completed
> and you have received their Acked-by or Reviewed-by tags, please
> send the series with those tags to soc at kernel.org for inclusion, keeping
> everyone else on Cc.
> 
> I'd leave it up to Linus Walleij whether he wants to merge the pinctrl driver
> through his subsystem tree, or whether we should pick it up through
> the soc tree, either way works for the initial merge. For any updates to
> the pinctrl driver and additional subsystem support (clk, media, ...)
> in later releases there is no need to Cc the SoC maintainers as those
> should just get merged through the subsystem while we take care
> of the DT files.

Thank you for the explanation. I will do that.
BTW, I searched the process for this but I couldn't find any detailed
documentation. Could you tell me if you know?

> 
> > NOTE: Because Visconti5 does not have PSCI, it uses spin-table with enable-method.
> 
> This sounds like an odd choice. Is this a permanent defect in the SoC
> or the firmware, or do you expect to change this later once the firmware
> has been fixed?

I will change it later when the firmware is fixed.

> 
> Note that most systems require PSCI anyway for cpuidle support. If there
> is any EL2 or EL3 mode firmware already, this is where support for
> processor bringup should be implemented. If there is none, you can
> usually implement it using a small EL3 trampoline in the bootloader.
> 

Yes, I understand that.
Our firmware team and I are currently considering a fix.

> >       And this patch series does not include a clock framework, so it is a
> >       device-tree file that uses clocks with fixed-clock. This will be replaced by
> >       the clock driver in the future.
> 
> This is ok for bringup, though we usually recommend to merge the clk driver
> at the same time as the SoC, in order to avoid having an incompatible DT
> change when adding the clk driver.

Yes, I do this with caution.

> 
>        Arnd
>

Best regards,
  Nobuhiro