[PATCH] ARM: dts: stm32: Add alternate pinmux for RCC pin

Alexandre Torgue alexandre.torgue at st.com
Fri Aug 28 08:38:32 EDT 2020


Hi Marek

On 8/22/20 10:35 PM, Marek Vasut wrote:
> Add another mux option for RCC pin, this is used on AV96 board.
> 
> Upstream-Status: Work-in-progress
> Signed-off-by: Marek Vasut <marex at denx.de>
> Cc: Alexandre Torgue <alexandre.torgue at st.com>
> Cc: Manivannan Sadhasivam <manivannan.sadhasivam at linaro.org>
> Cc: Maxime Coquelin <mcoquelin.stm32 at gmail.com>
> Cc: Patrice Chotard <patrice.chotard at st.com>
> Cc: Patrick Delaunay <patrick.delaunay at st.com>
> Cc: linux-stm32 at st-md-mailman.stormreply.com
> To: linux-arm-kernel at lists.infradead.org
> ---
>   arch/arm/boot/dts/stm32mp15-pinctrl.dtsi | 15 +++++++++++++++
>   1 file changed, 15 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/stm32mp15-pinctrl.dtsi b/arch/arm/boot/dts/stm32mp15-pinctrl.dtsi
> index ba8f52ea7674..1c4c3d32efae 100644
> --- a/arch/arm/boot/dts/stm32mp15-pinctrl.dtsi
> +++ b/arch/arm/boot/dts/stm32mp15-pinctrl.dtsi
> @@ -1051,6 +1051,21 @@ pins {
>   		};
>   	};
>   
> +	rcc_pins_a: rcc-pins-0 {

I would prefer: rcc_mco1_pins_a: rcc_mco1-0.

> +		pins {
> +			pinmux = <STM32_PINMUX('A', 13, AF2)>; /* RCC_MCO_1 */
> +			bias-disable;
> +			drive-push-pull;
> +			slew-rate = <1>;
> +		};
> +	};
> +
> +	rcc_sleep_pins_a: rcc-sleep-pins-0 {

Same kind of updates here.

Those pins are defined but never used. I would prefer to keep only used 
pins.

cheers
Alex

> +		pins {
> +			pinmux = <STM32_PINMUX('A', 13, ANALOG)>; /* RCC_MCO_1 */
> +		};
> +	};
> +
>   	sai2a_pins_a: sai2a-0 {
>   		pins {
>   			pinmux = <STM32_PINMUX('I', 5, AF10)>, /* SAI2_SCK_A */
> 



More information about the linux-arm-kernel mailing list