[PATCH v2 4/5] fpga manager: xilinx-spi: add error checking after gpiod_get_value()

Tom Rix trix at redhat.com
Thu Aug 27 15:04:23 EDT 2020


On 8/27/20 7:32 AM, Luca Ceresoli wrote:
> Current code calls gpiod_get_value() without error checking. Should the
> GPIO controller fail, execution would continue without any error message.
>
> Fix by checking for negative error values.
>
> Reported-by: Tom Rix <trix at redhat.com>
> Signed-off-by: Luca Ceresoli <luca at lucaceresoli.net>
>
> ---

Thanks, this looks fine.

Reviewed-by: Tom Rix <trix at redhat.com>





More information about the linux-arm-kernel mailing list