[PATCH V4] net: dsa: mt7530: Add of_node_put() before break and return statements

David Miller davem at davemloft.net
Tue Aug 25 10:48:42 EDT 2020


From: Sumera Priyadarsini <sylphrenadin at gmail.com>
Date: Tue, 25 Aug 2020 01:33:11 +0530

> Every iteration of for_each_child_of_node() decrements
> the reference count of the previous node, however when control
> is transferred from the middle of the loop, as in the case of
> a return or break or goto, there is no decrement thus ultimately
> resulting in a memory leak.
> 
> Fix a potential memory leak in mt7530.c by inserting of_node_put()
> before the break and return statements.
> 
> Issue found with Coccinelle.
> 
> Signed-off-by: Sumera Priyadarsini <sylphrenadin at gmail.com>

Applied, thank you.



More information about the linux-arm-kernel mailing list