[PATCH V3] coresight: Make sysFS functional on topologies with per core sink

[Linu Cherian]

Hi Mathieu,

On Mon Aug 24, 2020 at 08:46:33AM -0600, Mathieu Poirier wrote:
> On Sat, 22 Aug 2020 at 07:18, Linu Cherian <linuc.decode at gmail.com> wrote:
> >
> > Hi Mathieu,
> >
> > > > diff --git a/drivers/hwtracing/coresight/coresight-etm-perf.c b/drivers/hwtracing/coresight/coresight-etm-perf.c
> > > > index 1a3169e69bb1..25041d2654e3 100644
> > > > --- a/drivers/hwtracing/coresight/coresight-etm-perf.c
> > > > +++ b/drivers/hwtracing/coresight/coresight-etm-perf.c
> > > > @@ -223,7 +223,7 @@ static void *etm_setup_aux(struct perf_event *event, void **pages,
> > > >             id = (u32)event->attr.config2;
> > > >             sink = coresight_get_sink_by_id(id);
> > > >     } else {
> > > > -           sink = coresight_get_enabled_sink(true);
> > > > +           sink = coresight_get_enabled_sink(NULL, true);
> > >
> > > It is time for this subsystem to move out of the prehistoric age.  Please remove
> > > the call to coresight_get_enabled_sink() entirely.  In the change log you can
> > > write that selecting a sink from sysfs is deprecated when using the perf
> > > interface.  I will personally refactor the code if someone complains that it
> > > broke their user space.
> >
> 
> I forgot to mention... Please do two patches, one that removes
> coresight_get_enabled_sink() from etm_setup_aux() and another one for
> the reset of your changes.

Yeah. Sure.


-- 
Linu cherian